Close previous response body on flush. (THRIFT-3277) #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connections were being leaked as Flush created new responses without closing the previous response body.
degupta
pushed a commit
to degupta/thrift
that referenced
this pull request
Sep 23, 2016
…equests Client: Go Patch: Prashant Varanasi <prashant@uber.com> This closes apache#571
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
…equests Client: Go Patch: Prashant Varanasi <prashant@uber.com> This closes apache#571
hsanjuan
pushed a commit
to gxed/thrift-go
that referenced
this pull request
Jan 30, 2019
…equests Client: Go Patch: Prashant Varanasi <prashant@uber.com> This closes apache#571
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Apr 14, 2019
…nConnectFailure is set (apache#571)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections were being leaked as Flush created new responses without closing the previous response body.
See THRIFT-3277 for more information.