THRIFT-3306: Java: TBinaryProtocol: Use a single temp byte[] buffer#596
Closed
evanj wants to merge 1 commit intoapache:masterfrom
evanj:THRIFT-3306
Closed
THRIFT-3306: Java: TBinaryProtocol: Use a single temp byte[] buffer#596evanj wants to merge 1 commit intoapache:masterfrom evanj:THRIFT-3306
evanj wants to merge 1 commit intoapache:masterfrom
evanj:THRIFT-3306
Conversation
Reduces allocations and GC when TBinaryProtocol is allocated repeatedly. Originally separate byte[] arrays were allocated for each integer type, and a separate array for input and output. However, one buffer of the largest size (8 bytes for i64) can be used for all purposes.
Author
|
Note: the Travis CI build may have failed, but it failed to compile some parts of the C++ code, so I suspect this is due to a flaky test and is not legitimate, since I didn't touch any of the C++ stuff. |
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
Reduces allocations and GC when TBinaryProtocol is allocated repeatedly. Originally separate byte[] arrays were allocated for each integer type, and a separate array for input and output. However, one buffer of the largest size (8 bytes for i64) can be used for all purposes. This closes apache#596
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces allocations and GC when TBinaryProtocol is allocated repeatedly.
Originally separate byte[] arrays were allocated for each integer type, and
a separate array for input and output. However, one buffer of the largest
size (8 bytes for i64) can be used for all purposes.