Skip to content

THRIFT-3407 Refill buffer when JSON closing bracket is missing #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nsuke wants to merge 1 commit into from
Closed

THRIFT-3407 Refill buffer when JSON closing bracket is missing #678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/nodejs/lib/thrift/json_protocol.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,8 @@ TJSONProtocol.prototype.readMessageBegin = function() {
}

if (openBracketCount !== 0) {
throw new Error("Malformed JSON input, mismatched backets");
// Missing closing bracket. Can be buffer underrun.
throw new InputBufferUnderrunError();
}

//Reconstitute the JSON object and conume the necessary bytes
Expand Down