Closed
Conversation
Client: Compiler (general) Patch: Jens Geyer
gadLinux
pushed a commit
to gadLinux/thrift
that referenced
this pull request
Mar 6, 2016
Client: Compiler (general) Patch: Jens Geyer This closes apache#700
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
Client: Compiler (general) Patch: Jens Geyer This closes apache#700
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Apr 14, 2019
Before converting most of the project to C# 7, `netstandard2.0`, etc. I want to get unit tests in shape. There's a fair bit of complication to doing so in that we need to test against: - Different versions - Clusters - Master/Slave setups - Multiple-test unfriendly tests (like SHUTDOWN commands) - Simulate remote (read: latent) connections This work does a few things: - Moves all unit tests and assertions to xUnit - Enables parallelization for tests - Utilizes the xUnit output semantics, which means things like connection logs are on the test in VS, console output, build servers, etc. (it was a giant pool of `Console.WriteLine` mixed before) - Cleans up the `\packages` folder completely (it wasn't used for anything but the `redis-*.exe` binaries - Cleans up all test code formatting in general - Re-enables `net462` in testing (was only `netcoreapp1.0` before) - Allows overrides via `TestConfig.json` - Updates all the RedisConfig\ scripts for easy test running - Adds a StackExchange.Redis.Tests\README.md - Fixes many tests Remaining Long-term TODOs - Look at Redis 4.0 on Windows via WSL - Configure endpoints in a `.json` config override that's in `.gitignore` - Find a way to handle master/slave breaks on underpowered machines better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.