THRIFT-3502: C++ TServerSocket passes small buffer to getsockname #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When binding with a port number of 0, TServerSocket::listen calls getsockname to retrieve the bound port number. The previous code was passing too small a buffer as a parameter, failing on Windows with errno 2 and WSAGetLastError WSAEFAULT. This change fixes the issue by using struct sockaddr_storage instead of struct sockaddr as the parameter buffer.
gadLinux
pushed a commit
to gadLinux/thrift
that referenced
this pull request
Mar 6, 2016
Client: C++ Patch: Jeremy Spiegel This closes apache#761
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
Client: C++ Patch: Jeremy Spiegel This closes apache#761
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Apr 14, 2019
* Give defaultClientName a value when it is null This prevents calling TryGetAzureRoleInstanceIdNoThrow() repeatedly in the null case. * Upgrade xunit to 2.3.1 * Upgrade xunit to v2.4.0-beta1 to work around xunit/xunit#1601 * Move xUnit to 2.4.0-beta.1.build3958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When binding with a port number of 0, TServerSocket::listen calls
getsockname to retrieve the bound port number. The previous code was
passing too small a buffer as a parameter, failing on Windows with
errno 2 and WSAGetLastError WSAEFAULT. This change fixes the issue by
using struct sockaddr_storage instead of struct sockaddr as the
parameter buffer.