lib/py/test/test_sslsocket.py is flaky#850
Conversation
Previously a combination of fixed ports, fixed paths and delays was used in all TSSLSocketTest tests that involved making a client-server connection; now ephemeral ports, unique tmp files and no delays for successful connection tests are all implemented. A delay still remains for the failed connection tests to allow for SSL handshake initiation but not wait too long.
|
@nsuke - hoping you have time to review this one |
|
Noting that Jenkins CI failed on lib/cpp/test/SecurityTest.cpp before getting to test_sslsocket.py. |
| client.close() | ||
|
|
||
| # deprecated feature | ||
| def test_deprecation(self): |
There was a problem hiding this comment.
For some reason, deprecation count now differs between Python 2 and Python 3
https://travis-ci.org/apache/thrift/jobs/108805112#L2383
File "test/test_sslsocket.py", line 164, in test_deprecation
self.assertEqual(len(w), 7)
AssertionError: 6 != 7
I've found another issue on deprecate messages so I'll need to modify this part shortly after, after all.
So you can just skip this with if + print for now.
There was a problem hiding this comment.
will do - diff coming presently
There was a problem hiding this comment.
Just FIY, this is the issue https://issues.apache.org/jira/browse/THRIFT-3618
There was a problem hiding this comment.
Added a link to the issue in the comment - thanks!
Client: Test (Python) Patch: John Sirois Previously a combination of fixed ports, fixed paths and delays was used in all TSSLSocketTest tests that involved making a client-server connection; now ephemeral ports, unique tmp files and no delays for successful connection tests are all implemented. A delay still remains for the failed connection tests to allow for SSL handshake initiation but not wait too long. This closes apache#850
Client: Test (Python) Patch: John Sirois Previously a combination of fixed ports, fixed paths and delays was used in all TSSLSocketTest tests that involved making a client-server connection; now ephemeral ports, unique tmp files and no delays for successful connection tests are all implemented. A delay still remains for the failed connection tests to allow for SSL handshake initiation but not wait too long. This closes apache#850
2 participants
Previously a combination of fixed ports, fixed paths and delays was used
in all TSSLSocketTest tests that involved making a client-server
connection; now ephemeral ports, unique tmp files and no delays for
successful connection tests are all implemented. A delay still remains
for the failed connection tests to allow for SSL handshake initiation
but not wait too long.