THRIFT-3702 Fix cross tests for Dart compact protocol (3 failing)#917
Closed
markerickson-wf wants to merge 1 commit intoapache:masterfrom
Closed
THRIFT-3702 Fix cross tests for Dart compact protocol (3 failing)#917markerickson-wf wants to merge 1 commit intoapache:masterfrom
markerickson-wf wants to merge 1 commit intoapache:masterfrom
Conversation
… appears to be empty. Go server - Java client also fails for me for http. So without much more time to investigate, I think the best course of action is to add these to known_failures_Linux.json to allow CI to pass. There are already other combinations excluded for those server - transport pairs. go-dart compact http-ip failure(13) hs-dart compact framed-ip failure(13) cpp-dart compact http-ip failure(13) THRIFT-3702
|
+1 |
1 similar comment
Contributor
|
+1 |
gadLinux
pushed a commit
to gadLinux/thrift
that referenced
this pull request
Mar 6, 2016
Client: Dart Patch: Mark Erickson This closes apache#917
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
Client: Dart Patch: Mark Erickson This closes apache#917
ngrewe
pushed a commit
to ngrewe/thrift
that referenced
this pull request
Jan 31, 2017
Client: Dart Patch: Mark Erickson This closes apache#917
ngrewe
pushed a commit
to ngrewe/thrift
that referenced
this pull request
Jan 31, 2017
Client: Dart Patch: Mark Erickson This closes apache#917
jeking3
pushed a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
Client: Dart Patch: Mark Erickson This closes apache#917
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked at Go-Dart locally, and the response body from the Go server appears to be empty. Go server - Java client also fails for me for http. So without much more time to investigate, I think the best course of action is to add these to known_failures_Linux.json to allow CI to pass. There are already other combinations excluded for those server - transport pairs.
I did some cleanup in the Dart test client while I was in there.
go-dart compact http-ip failure(13)
hs-dart compact framed-ip failure(13)
cpp-dart compact http-ip failure(13)
https://issues.apache.org/jira/browse/THRIFT-3702
@brianshannan-wf
@stevenosborne-wf
@tylertreat-wf