TINKERPOP-2141: Rewind buffer's position in ByteBufferSerializer#1045
Merged
spmallette merged 1 commit intoapache:masterfrom Jan 24, 2019
Merged
TINKERPOP-2141: Rewind buffer's position in ByteBufferSerializer#1045spmallette merged 1 commit intoapache:masterfrom
spmallette merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Good catch and fix! VOTE +1 |
The reason this wasn't caught by the existing test is because `ByteBuffer.allocate(8).putLong(123456)` also modifies the buffer's position
nastra
force-pushed
the
TINKERPOP-2141
branch
from
176385f to
f4652d1
Compare
Contributor
|
VOTE +1 |
1 similar comment
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.