Skip to content

TINKERPOP-2141: Rewind buffer's position in ByteBufferSerializer #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spmallette merged 1 commit into from
Jan 24, 2019
Merged

TINKERPOP-2141: Rewind buffer's position in ByteBufferSerializer #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../main/java/org/apache/tinkerpop/gremlin/driver/ser/binary/types/ByteBufferSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public ByteBufferSerializer() {
ByteBuffer readValue(final ByteBuf buffer, final GraphBinaryReader context) throws SerializationException {
final ByteBuffer bb = ByteBuffer.allocate(buffer.readInt());
buffer.readBytes(bb);
bb.rewind();
return bb;
}

Expand Down
2 changes: 1 addition & 1 deletion .../org/apache/tinkerpop/gremlin/driver/ser/binary/GraphBinaryReaderWriterRoundTripTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public static Collection input() throws Exception {
new Object[] {"Binding", new Bytecode.Binding<>("x", 123), null},
new Object[] {"Traverser", new DefaultRemoteTraverser<>("marko", 100), null},
new Object[] {"Class", Bytecode.class, null},
new Object[] {"ByteBuffer", ByteBuffer.allocate(8).putLong(123456), null},
new Object[] {"ByteBuffer", ByteBuffer.wrap(new byte[]{ 1, 2, 3 }), null},
new Object[] {"InetAddressV4", InetAddress.getByName("localhost"), null},
new Object[] {"InetAddressV6", InetAddress.getByName("::1"), null},
new Object[] {"Lambda0", Lambda.supplier("return 1"), null},
Expand Down