[TINKERPOP-2841] Test and Fix Per-Request Settings in Go GLV#1939
Merged
vkagamlyk merged 1 commit intoapache:masterfrom Feb 9, 2023
Merged
[TINKERPOP-2841] Test and Fix Per-Request Settings in Go GLV#1939vkagamlyk merged 1 commit intoapache:masterfrom
vkagamlyk merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1939 +/- ##
============================================
+ Coverage 68.58% 68.98% +0.39%
+ Complexity 9094 9089 -5
============================================
Files 854 830 -24
Lines 41188 37457 -3731
Branches 5598 5598
============================================
- Hits 28250 25839 -2411
+ Misses 10962 9808 -1154
+ Partials 1976 1810 -166
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Cole-Greer
force-pushed
the
cole/go-per-request-settings
branch
from
9d08d0d to
0e512cf
Compare
Contributor
|
LGTM, thanks Cole! VOTE +1 |
Go was previously not sending per-request options correctly to the server. Go was passing request options inside the gremlin script bindings map instead of within the args portion of the request message. This commit resolves this issue by encapsulating all per-request settings as well as script bindings into a new RequestOptions struct which has an accompanying RequestOptionsBuilder. This can now be passed in through new Client.SubmitWithOptions() and DriverRemoteConnection.SubmitWithOptions() methods. Both original Submit() methods are unchanged in their behavior so this will not break any users.
Cole-Greer
force-pushed
the
cole/go-per-request-settings
branch
from
0e512cf to
c16da29
Compare
Contributor
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2841
In my testing, the go glv was not sending per-request options correctly to the server. Go was passing request options inside the gremlin script bindings map instead of within the args portion of the request message.
This PR re-implements the per-request settings by adding new Client.SubmitWithOptions() and DriverRemoteConnection.SubmitWithOptions() methods. Both original Submit() methods are unchanged in their behavior so this will not break any users.
This PR introduces a new
RequestOptionsstruct and builder which is used to configure per-request settings and passed into the new SubmitWithOptions() methods.