[TINKERPOP-2841] Fix Per-Request Settings in Go GLV 3.5#1968
Merged
xiazcy merged 1 commit intoapache:3.5-devfrom Feb 22, 2023
Merged
[TINKERPOP-2841] Fix Per-Request Settings in Go GLV 3.5#1968xiazcy merged 1 commit intoapache:3.5-devfrom
xiazcy merged 1 commit intoapache:3.5-devfrom
Conversation
Contributor
|
VOTE +1 |
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #1968 +/- ##
=============================================
+ Coverage 69.26% 69.36% +0.10%
- Complexity 8940 8952 +12
=============================================
Files 865 866 +1
Lines 41095 41145 +50
Branches 5418 5418
=============================================
+ Hits 28466 28542 +76
+ Misses 10712 10689 -23
+ Partials 1917 1914 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Go was previously not sending per-request options correctly to the server. Go was passing request options inside the gremlin script bindings map instead of within the args portion of the request message. This commit resolves this issue by encapsulating all per-request settings as well as script bindings into a new RequestOptions struct which has an accompanying RequestOptionsBuilder. This can now be passed in through new Client.SubmitWithOptions() and DriverRemoteConnection.SubmitWithOptions() methods. Both original Submit() methods are unchanged in their behavior so this will not break any users.
Cole-Greer
force-pushed
the
cole/go-request-options-3.5
branch
from
5e269ac to
f6879ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2841
This PR is cherry picking the changes introduced in #1939 back to 3.5.x with the socket server based tests removed for compatibility. There are no changes to the existing external interface (other than adding a new SubmitWithOptions() method). This is not a breaking change for any users.