Update nullability for AsString(), Conjoin() in Gremlin.Net#2360
Merged
xiazcy merged 1 commit intoapache:3.7-devfrom Dec 8, 2023
Merged
Conversation
Handling of null values has been changed in apache#2351 for `asString()` and `conjoin()` to return `null` for `null` values instead of the string `"null"`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.7-dev #2360 +/- ##
=============================================
+ Coverage 76.16% 76.18% +0.01%
- Complexity 13108 13114 +6
=============================================
Files 1083 1083
Lines 64995 64995
Branches 7259 7259
=============================================
+ Hits 49504 49516 +12
+ Misses 12792 12783 -9
+ Partials 2699 2696 -3 ☔ View full report in Codecov by Sentry. |
Contributor
|
VOTE +1 |
1 similar comment
Contributor
|
VOTE +1 |
Contributor
|
VOTE +1 (pending branch re-opening) |
kenhuuu
approved these changes
Dec 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handling of null values has been changed in #2351 for
asString()andconjoin()to returnnullfornullvalues instead of the string"null".Just to clarify: I don't consider this change important enough to stop the current release process. This can just be included in the next line of releases.