Skip to content

Update nullability for AsString(), Conjoin() in Gremlin.Net #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiazcy merged 1 commit into from
Dec 8, 2023
Merged

Update nullability for AsString(), Conjoin() in Gremlin.Net #2360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions gremlin-dotnet/src/Gremlin.Net/Process/Traversal/GraphTraversal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,19 +226,19 @@ public GraphTraversal<TStart, TEnd> As (string stepLabel, params string[] stepLa
/// <summary>
/// Adds the asString step to this <see cref="GraphTraversal{SType, EType}" />.
/// </summary>
public GraphTraversal<TStart, string> AsString ()
public GraphTraversal<TStart, string?> AsString ()
{
Bytecode.AddStep("asString");
return Wrap<TStart, string>(this);
return Wrap<TStart, string?>(this);
}

/// <summary>
/// Adds the asString step to this <see cref="GraphTraversal{SType, EType}" />.
/// </summary>
public GraphTraversal<TStart, TNewEnd> AsString<TNewEnd> (Scope scope)
public GraphTraversal<TStart, TNewEnd?> AsString<TNewEnd> (Scope scope)
{
Bytecode.AddStep("asString", scope);
return Wrap<TStart, TNewEnd>(this);
return Wrap<TStart, TNewEnd?>(this);
}

/// <summary>
Expand Down Expand Up @@ -591,10 +591,10 @@ public GraphTraversal<TStart, string> Concat (params string?[] concatStrings)
/// <summary>
/// Adds the conjoin step to this <see cref="GraphTraversal{SType, EType}" />.
/// </summary>
public GraphTraversal<TStart, TEnd> Conjoin (string delimiter)
public GraphTraversal<TStart, TEnd?> Conjoin (string delimiter)
{
Bytecode.AddStep("conjoin", delimiter);
return Wrap<TStart, TEnd>(this);
return Wrap<TStart, TEnd?>(this);
}

/// <summary>
Expand Down
6 changes: 3 additions & 3 deletions gremlin-dotnet/src/Gremlin.Net/Process/Traversal/__.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,15 +155,15 @@ public static GraphTraversal<object, object> As(string label, params string[] la
/// <summary>
/// Spawns a <see cref="GraphTraversal{SType, EType}" /> and adds the asString step to that traversal.
/// </summary>
public static GraphTraversal<object, string> AsString()
public static GraphTraversal<object, string?> AsString()
{
return new GraphTraversal<object, string>().AsString();
}

/// <summary>
/// Spawns a <see cref="GraphTraversal{SType, EType}" /> and adds the asString step to that traversal.
/// </summary>
public static GraphTraversal<object, E2> AsString<E2>(Scope scope)
public static GraphTraversal<object, E2?> AsString<E2>(Scope scope)
{
return new GraphTraversal<object, E2>().AsString<E2>(scope);
}
Expand Down Expand Up @@ -381,7 +381,7 @@ public static GraphTraversal<object, string> Concat(params string?[] concatStrin
/// <summary>
/// Spawns a <see cref="GraphTraversal{SType, EType}" /> and adds the conjoin step to that traversal.
/// </summary>
public static GraphTraversal<object, object> Conjoin(string delimiter)
public static GraphTraversal<object, object?> Conjoin(string delimiter)
{
return new GraphTraversal<object, object>().Conjoin(delimiter);
}
Expand Down