Conversation
This is just the type serializers but not the message serializers which will be implemented later. Uses the same style as GraphBinary1 despite not having custom types.
Implement non-streaming HTTP in .NET while replacing all WebSocket reference and settings. Message serializers are also updated.
…it request and response serializer to allow user customization and moved MimeType into IMessageSerializer (#3334)
Contributor
|
Having previously reviewed all commits in from the branch already, my VOTE is +1. |
Contributor
|
I've also previously reviewed all commits into this branch. VOTE +1 (pending tests passing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An overall feature-complete
gremlin-dotnetover HTTP for the 4.0.0 branch. Includes commits from previously reviewed PRs, so I expect this to be a quick one to merge.Remaining work for follow-up during Beta 2 code freeze would be the removal of all GraphSON serializers. Streaming HTTP improvement will be saved for 4.0.0 GA.
VOTE +1