TINKERPOP-1338 Bumped groovy to 2.4.7#356
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 8, 2016
Merged
Conversation
Member
Author
|
Fixed my Spark issue. Wanted to rebuild since giraph, hadoop, and spark have some dependency on groovy. Builds cleanly with mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false |
Contributor
|
Note that it's not sufficient in this case to only run gremlin server integration tests. You should probably run the whole suite. When i run that with docker via I assume this is because of #353 (just a guess) - perhaps you need to rebase now that this issue is merged? |
Contributor
|
looks like this is failing in master too..........so it's unrelated to your change. we will need to get that fixed and at that point you should rebase and try to full integration tests suite. i'll post back here when that's fixed on master |
Member
Author
robertdale
force-pushed
the
TINKERPOP-1338
branch
from
fe37df2 to
eaa2a23
Compare
robertdale
force-pushed
the
TINKERPOP-1338
branch
from
eaa2a23 to
5ff91f7
Compare
Member
Author
|
I rebased to include @okram 's fix in the jira ticket. 4.5 hours later, "docker/build.sh -t -i -n" passed! |
Contributor
|
VOTE +1. |
Contributor
|
VOTE: +1 |
Contributor
|
All tests pass with VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new dependencies introduced.
No other dependency versions changed.
Successful build and verify with:
mvn clean install -pl gremlin-shaded,gremlin-core,gremlin-test,gremlin-groovy,gremlin-groovy-test,tinkergraph-gremlin,neo4j-gremlin,gremlin-driver,gremlin-console,gremlin-server,gremlin-archetype && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j
(excludes giraph-gremlin, hadoop-gremlin,spark-gremlin because I have separate issues building them)