TinkerGraph refactor: extract interface, rename implementations - #3582
Merged
Conversation
xiazcy
reviewed
Aug 5, 2026
Comment on lines
313
to
315
| ==>tinkertransactiongraph[vertices:0 edges:0] | ||
| gremlin> g = traversal().with(graph) | ||
| ==>graphtraversalsource[tinkertransactiongraph[vertices:0 edges:0], standard] |
Contributor
There was a problem hiding this comment.
Suggested change
| ==>tinkertransactiongraph[vertices:0 edges:0] | |
| gremlin> g = traversal().with(graph) | |
| ==>graphtraversalsource[tinkertransactiongraph[vertices:0 edges:0], standard] | |
| ==>tinkerstoragegraph[vertices:0 edges:0] | |
| gremlin> g = traversal().with(graph) | |
| ==>graphtraversalsource[tinkerstoragegraph[vertices:0 edges:0], standard] |
xiazcy
reviewed
Aug 5, 2026
Contributor
There was a problem hiding this comment.
Suggested change
| ==>graphtraversalsource[tinkerstoragegraph[vertices:1 edges:0], standard] |
Contributor
|
Just found some stale references in the docs, not sure if those would get picked up automatically by docs generation. VOTE +1 |
TinkerGraph is now an interface with two implementations: TinkerMemoryGraph (in-memory, what TinkerGraph.open() returns) and TinkerStorageGraph (the transactional graph formerly named TinkerTransactionGraph). Existing code using TinkerGraph.open() or gremlin.graph=...TinkerGraph works unchanged. Assisted-by: Claude Code:claude-fable-5
spmallette
force-pushed
the
tinkergraph-refactor
branch
from
August 12, 2026 12:10
a548cec to
c11e0a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TinkerGraph is now an interface with two implementations:
TinkerMemoryGraph(in-memory, whatTinkerGraph.open()returns) andTinkerStorageGraph(the transactional graph formerly namedTinkerTransactionGraph). Existing code usingTinkerGraph.open()orgremlin.graph=...TinkerGraphworks unchanged.Starting point to changes described here: https://lists.apache.org/thread/2zt62kvfssh6xz5vnf2lk1g7cstq9vod
VOTE +1