TINKERPOP-1399 NumberHelper needs to go into util and have a private constructor#487
Merged
TINKERPOP-1399 NumberHelper needs to go into util and have a private constructor#487
Conversation
Contributor
|
VOTE +0.99. |
asfgit
force-pushed
the
TINKERPOP-1399
branch
from
05331f2 to
df84bc9
Compare
Contributor
|
The title of this PR says to make |
Contributor
Author
|
It only has a private constructor already. Making it final is a good call though. |
Contributor
|
oh - sorry - i see it now. i had to expand out the diff. i did a quick VOTE +1 |
Member
|
VOTE: +0.01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1399
Moved
NumberHelperintoorg.apache.tinkerpop.gremlin.util. Note that it's not necessary to add a private constructor, since the only constructor that exists, is already private.VOTE: +1