TINKERPOP-1143 Moved TraversalEngine to gremlin-test#830
Merged
Conversation
dkuppitz
reviewed
Apr 6, 2018
| if (this.first) { | ||
| this.first = false; | ||
| this.initializeMatchAlgorithm(TraversalEngine.Type.STANDARD); | ||
| this.initializeMatchAlgorithm(true); |
Contributor
Author
There was a problem hiding this comment.
oh wow - good catch. i guess the tests pass either way though...don't know if that's bad.???
Contributor
There was a problem hiding this comment.
It's not bad. I don't fully understand the code in CountMatchAlgorithm (the only place where the boolean flag makes a difference), but it seems like it only reorders the match traversals, possibly to optimize memory consumption and/or processing time.
Contributor
Author
There was a problem hiding this comment.
that makes sense - fixed and pushed
TraversalEngine and related infrastructure was deprecated way back on 3.2.0 but it was kept around because it was used in some infrastructure for testing. Graph providers should in no way still be using this interface and should have long ago gone to Computer as the gremlin-core infrastructure long ago quit using TraversalEngine in any capacity.
Contributor
|
VOTE: +1 |
Member
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-1143
TraversalEngineand related infrastructure was deprecated way back on 3.2.0 but it was kept around because it was used in some infrastructure for testing. Graph providers should in no way still be using this interface and should have long ago gone toComputeras thegremlin-coreinfrastructure long ago quit usingTraversalEnginein any capacity.The only weird part was that
MatchStepusedTraversalEngineas a switch - I just converted that to use a boolean for checks that determine if the step is being executedonComputeror not.All tests pass with
docker/build.sh -t -n -iVOTE +1