TINKERPOP-2053 Support for OptionsStrategy#945
Merged
spmallette merged 6 commits intomasterfrom Oct 8, 2018
Merged
Conversation
Member
|
VOTE +1 |
1 similar comment
Contributor
|
VOTE +1 |
Included a test in TinkerGraph rather than the main test suite because the test really isn't easily asserted without a custom step that reads the OptionsStrategy.
Expecting TINKERPOP-2041 to merge first which is using 186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2053
OptionsStrategylets users pass arbitrary configurations at a traversal level. At first I thought this might be a first class object, but decided instead to try it out as aTraversalStrategy. In that way it was implemented with little overhead. If it becomes useful and popular in the future then we can consider making it more integrated into theTraversalSourceandTraversalitself. I didn't implement this for javascript because I don't think we have all the infrastructure there for supportingTraversalStrategystuff yet.All tests pass with
docker/build.sh -t -iVOTE +1