TINKERPOP-2056 Use NumberHelper in Compare#949
Merged
Merged
Conversation
Contributor
|
Just pushed a commit 4bdb006 on the release branches to deal with these pesky tests that sometimes fail in travis: Obviously not related to this change. Did you happen to do any tests to see what this optimization bought us in terms of performance? VOTE +1 |
Contributor
Author
|
From what we've seen in previous tests, it should be marginally faster. I haven't run any new tests as this was more about consistency. |
Member
|
VOTE +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2056
Instead of converting all numbers to
BigDecimal,Comparepredicates now useNumberHelperfor numerical comparisons.docker/build.sh -t -i -npassed.VOTE +1