[TOMEE-2296] - MicroProfile Fault Tolerance Example for @Timeout - #382
Closed
josehenriqueventura wants to merge 6 commits into
Closed
[TOMEE-2296] - MicroProfile Fault Tolerance Example for @Timeout#382josehenriqueventura wants to merge 6 commits into
josehenriqueventura wants to merge 6 commits into
Conversation
brunobat
suggested changes
Jan 28, 2019
brunobat
left a comment
brunobat
left a comment
Contributor
There was a problem hiding this comment.
Hi José,
Thanks for you PR!
The code works ok and is nicely explained.
I've left a couple of suggestions.
* Changed the Timeout value from 1000 to 50 * Changed longProcessingTask sleep time from 1100 to 80 README.adoc * Updated the snippet code to reflect what was changed in WeatherGateway.java plus the URL to point to the correct endpoint
brunobat
approved these changes
Jan 29, 2019
brunobat
left a comment
brunobat
left a comment
Contributor
There was a problem hiding this comment.
Hi @josehenriqueventura it looks good to me now.
Thanks very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have completed the Faul Tolerance Timeout example!