This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix Monitor Thresholds#3646
Merged
mitchell852 merged 3 commits intoapache:masterfrom Jun 18, 2019
Merged
Conversation
rob05c
added
bug
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
ezelkow1
approved these changes
Jun 17, 2019
This fixes the Monitor racing and the health poll marking Available caches which were marked Unavailable by the Stat poll. There was already logic to prevent that, but it wasn't accounting for the Calculated stats, so the Health poll didn't check Calculated stats for thresholds, but it does "have" those stats, so it thought it could mark them available again. This fixes the Health poll to also check thresholds for Calculated stats, which not only fixes the race, but makes thresholds be marked up and down faster with the quicker Health poll.
rob05c
force-pushed
the
fix-tm-thresholds
branch
from
f440a3d to
10ddeab
Compare
Member
Author
|
@ezelkow1 Done. |
Contributor
|
Refer to this link for build results (access rights to CI server needed): |
dsouza93
approved these changes
Jun 18, 2019
dsouza93
left a comment
dsouza93
left a comment
There was a problem hiding this comment.
Looks good. I was able to reproduce the bug in the nightly environment. I set the threshold to a very high parameter and noticed that the state was flapping.
When running this same test with an updated traffic monitor, the caches are placed in a down state and remain there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the Monitor racing and the health poll marking Available
caches which were marked Unavailable by the Stat poll.
There was already logic to prevent that, but it wasn't accounting
for the Calculated stats, so the Health poll didn't check Calculated
stats for thresholds, but it does "have" those stats, so it thought
it could mark them available again.
This fixes the Health poll to also check thresholds for Calculated
stats, which not only fixes the race, but makes thresholds be
marked up and down faster with the quicker Health poll.
Includes unit tests.
Bug fix, no interface change, so no documentation change.
Includes changelog.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Set low availableKbps thresholds, run the monitor, verify in the Event Log and Cache States that caches are marked unavailable from kbps threshold, verify health poll does not mark caches that remain above the threshold as available, and that caches remain Unavailable (unless they drop below the threshold).
If this is a bug fix, what versions of Traffic Ops are affected?
The following criteria are ALL met by this PR