This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Tpv2 coordinates #7364
Merged
Tpv2 coordinates #7364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7364 +/- ##
============================================
+ Coverage 26.04% 26.15% +0.11%
Complexity 98 98
============================================
Files 595 648 +53
Lines 73737 76198 +2461
Branches 90 90
============================================
+ Hits 19208 19933 +725
- Misses 52657 54426 +1769
+ Partials 1872 1839 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 79 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shamrickus
suggested changes
Feb 28, 2023
docs/source/api/v4/deliveryservices_xmlid_xmlid_sslkeys_renew.rst
Outdated
Show resolved
Hide resolved
docs/source/api/v5/deliveryservices_xmlid_xmlid_sslkeys_renew.rst
Outdated
Show resolved
Hide resolved
ocket8888
added
new feature
…ordinate path in cache-group.service.ts. Added more decimal places to latitude and longitude in cache-group-details.component.html.
…ng test in coordinates-table.component.spec.ts.
kdamichie
force-pushed
the
tpv2_coordinates
branch
from
4304431 to
31b8722
Compare
shamrickus
suggested changes
Mar 3, 2023
Member
shamrickus
left a comment
shamrickus
left a comment
There was a problem hiding this comment.
Code otherwise looks good and everything works so once these last comments are addressed it should be good to go.
...ffic-portal/src/app/core/cache-groups/cache-group-details/cache-group-details.component.html
Outdated
Show resolved
Hide resolved
...ffic-portal/src/app/core/cache-groups/cache-group-details/cache-group-details.component.html
Outdated
Show resolved
Hide resolved
...traffic-portal/src/app/core/cache-groups/coordinates/detail/coordinate-detail.component.html
Outdated
Show resolved
Hide resolved
...traffic-portal/src/app/core/cache-groups/coordinates/detail/coordinate-detail.component.html
Outdated
Show resolved
Hide resolved
srijeet0406
force-pushed
the
tpv2_coordinates
branch
from
ac7cd08 to
70af3ad
Compare
shamrickus
reviewed
Mar 16, 2023
...al/traffic-portal/src/app/core/cache-groups/coordinates/table/coordinates-table.component.ts
Outdated
Show resolved
Hide resolved
shamrickus
approved these changes
Mar 16, 2023
Member
shamrickus
left a comment
shamrickus
left a comment
There was a problem hiding this comment.
LGTM
- Coordinates works and tests pass
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created TPv2 Parity page Coordinates.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Test that Coordinates exists and new coordinates can be created with name, latitude, and longitude. Verify Edit and Delete features function as well.
PR submission checklist