Build nuraft against shared OpenSSL on Ubuntu 26.04 - #458
Merged
Conversation
OpenSSL 3.5 lists "-lz" in the static half of its pkg-config file, so CMake's FindOpenSSL resolves zlib while it is restricted to static libraries and puts the non-PIC libz.a into libnuraft.so. amd64 rejects that relocation, so the ubuntu2604 image fails to build there while arm64 tolerates the same archive. This patch names the shared OpenSSL libraries, which keeps FindOpenSSL out of its static path and drops the zlib, jitterentropy, and zstd dependencies from the nuraft link entirely. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSL 3.5 lists "-lz" in the static half of its pkg-config file, so
CMake's FindOpenSSL resolves zlib while it is restricted to static
libraries and puts the non-PIC libz.a into libnuraft.so. amd64 rejects
that relocation, so the ubuntu2604 image fails to build there while
arm64 tolerates the same archive.
This patch names the shared OpenSSL libraries, which keeps FindOpenSSL
out of its static path and drops the zlib, jitterentropy, and zstd
dependencies from the nuraft link entirely.