Use dynamic dispatch for EventIO#10035
Merged
moonchen merged 4 commits intoapache:masterfrom Jul 31, 2023
Merged
Conversation
maskit
reviewed
Jul 13, 2023
moonchen
force-pushed
the
eventio-dynamic-dispatch-rebase
branch
from
74c41c1 to
57533df
Compare
maskit
reviewed
Jul 17, 2023
maskit
reviewed
Jul 17, 2023
moonchen
force-pushed
the
eventio-dynamic-dispatch-rebase
branch
from
57533df to
8a6bf9a
Compare
moonchen
force-pushed
the
eventio-dynamic-dispatch-rebase
branch
from
b6dee58 to
9294c6c
Compare
Contributor
Author
|
[approve ci clang-analyzer] |
Contributor
Author
|
AuTests fixed by #10067 |
ywkaras
reviewed
Jul 25, 2023
iocore/dns/DNSEventIO.cc
Outdated
| @@ -0,0 +1,38 @@ | |||
| /** @file | |||
|
|
|||
| A brief file description | |||
ywkaras
reviewed
Jul 25, 2023
iocore/net/AsyncSignalEventIO.cc
Outdated
| { | ||
| #if HAVE_EVENTFD | ||
| uint64_t counter; | ||
| ATS_UNUSED_RETURN(read(_fd, &counter, sizeof(uint64_t))); |
Contributor
There was a problem hiding this comment.
I' d suggest instead:
static_cast<void>(read(_fd, &counter, sizeof(uint64_t)));
ywkaras
approved these changes
Jul 31, 2023
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Aug 3, 2023
Instead of using branches, use dynamic dispatch to process each EventIO. Mainly this helps with code organization, and untangles dependencies in iocore. Testing shows dynamic dispatch to be no worse than branching (approximately 0.5% +- 0.2% better rps).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using branches, use dynamic dispatch to process each EventIO. Mainly this helps with code organization, and untangles dependencies in iocore.
Testing shows dynamic dispatch to be no worse than branching (approximately 0.5% +- 0.2% better rps).