Revert "Bump minimum CMake version from 3.20 to 3.26"#10065
Conversation
This reverts commit c1c27f8.
|
We discussed this in the PR review meeting and I was told it was easy to upgrade to CMake 3.26. What changed? |
It is easy to upgrade. But we decided it was best to still keep things at 3.20 which is what rockylinux:8 has, so that should be both reasonable for cmake dev and convenient for users. |
|
We want to test with our minimum version in CI, but we also don't want things to break when we increase the minimum version in the future. Setting a version range should set policies to One note on this: I just ran into a case where a version range apparently had no effect on policies. I don't know whether there's something I was missing, or whether it's a CMake bug of some sort. |
I'm not familiar enough with cmake to understand this part, but my understanding is that the motivation is basically the same as running CI jobs with C++17 and also C++20 where we only use C++17 features at the movement but ensure nothing won't be broken when we move to C++20.. Sounds reasonable to me. |
Reverts #10053
We'll change this to a range from 3.20-3.26 since we decided to keep support for at least 3.20 to maintain support for older OS's.