Shutdown tests: update backing sleep command to 10#10077
Merged
bneradt merged 1 commit intoapache:masterfrom Jul 24, 2023
Merged
Shutdown tests: update backing sleep command to 10#10077bneradt merged 1 commit intoapache:masterfrom
bneradt merged 1 commit intoapache:masterfrom
Conversation
The Ready conditions for some await processes waited upon the existence of a log entry before continuing. This works fine, but the process behind some of them was a 1 second sleep. If the sleep finished before the file existed, which should be rare for these tests but possible, the test would fail because the process finished before the process was "ready". This updates the backing sleep commands to 10 second sleeps which should afford plenty of time for the watch processes to see their file content. This may make these tests more reliable in CI.
randall
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ready conditions for some await processes waited upon the existence of a log entry before continuing. This works fine, but the process behind some of them was a 1 second sleep. If the sleep finished before the file existed, which should be rare for these tests but possible, the test would fail because the process finished before the process was "ready". This updates the backing sleep commands to 10 second sleeps which should afford plenty of time for the watch processes to see their file content. This may make these tests more reliable in CI.