Fix inkevent dependency tree for CMake build#10080
Merged
bneradt merged 1 commit intoapache:masterfrom Jul 24, 2023
Merged
Conversation
This declares an explicit dependency on inkevent for all its direct dependents, and removes redundant includes. IOCORE_INCLUDE_DIRS is left untouched, because some targets have transitive dependencies on inkevent, but don't have the usage requirement on the direct dependency declared.
cmcfarlen
approved these changes
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This declares an explicit dependency on inkevent for all its direct dependents, and removes redundant includes. IOCORE_INCLUDE_DIRS is left untouched, because some targets have transitive dependencies on inkevent, but don't have the usage requirement on the direct dependency declared.
