TS-4498 Remap plugin initialization failure error messages (back-port). #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add error logging of the returned error message if a remap plugin fails to initialize. Currently it just says "bailing out" which is not as useful. (cherry-picked from commit 42becd0)
Ran clang-format [6.2.x] produced different results than [7.0.x].
Contributor
Author
|
Confirmed no conflict on the cherry-picked commit. The second commit was due to clang-format differences between 7.0.x and 6.2.x. |
Contributor
|
[approve ci] |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1137/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1030/ for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jpeach -- James, we would like to request a back-port of this commit to 6.2.x. Thanks.