CID 1518613: Traffic Dump: fix a use after free of a mutex#10521
Merged
bneradt merged 1 commit intoapache:masterfrom Sep 27, 2023
Merged
CID 1518613: Traffic Dump: fix a use after free of a mutex#10521bneradt merged 1 commit intoapache:masterfrom
bneradt merged 1 commit intoapache:masterfrom
Conversation
Coverity found that Traffic Dump had code that locked a mutex via std::lock_guard, freed the owner of the mutex (and thus the mutex), and then, when the std::lock_guard went out of scope, unlocked the free'd mutex. This use after free is addressed in this patch by extending the lifetime of the SessionData object owning the mutex until after the lock is released. Fixes: apache#10331
bryancall
requested review from
cmcfarlen and
moonchen
and removed request for
moonchen
randall
approved these changes
Sep 26, 2023
moonchen
approved these changes
Sep 26, 2023
Contributor
|
@bneradt This gets merge conflicts because this plugin has moved on master. If you want this on 9.2.x, please make another branch PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverity found that Traffic Dump had code that locked a mutex via std::lock_guard, freed the owner of the mutex (and thus the mutex), and then, when the std::lock_guard went out of scope, unlocked the free'd mutex. This use after free is addressed in this patch by extending the lifetime of the SessionData object owning the mutex until after the lock is released.
Fixes: #10331
For Reviewers
This patch is easier to read if configured to ignore white space.