Add return values to hash operations #1058
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/890/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/785/ for details. |
Contributor
|
AFAICT from OpenSS source code, the hash update never fails. I would be OK with a release or debug assert that it doesn't rather than propagating return values. |
Member
|
I think I agree with @jpeach - it would be better to just drop the EVP return or assert() rather than changing the outer API to have more values that will be ignored. Won't Coverity complain about that after? |
Contributor
Author
|
Not if we check it nowhere. The problem is we check it >80% of the time in our code currently. |
Contributor
Author
|
See #1060 |
bneradt
pushed a commit
to bneradt/trafficserver
that referenced
this pull request
Jan 23, 2026
Co-authored-by: yahoo-samara[bot] <40247+yahoo-samara[bot]@users.noreply.git.ouryahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made this PR due to a coverity issue where we weren't checking the return value on an EVP hash function. An alternative to this approach is just to continue to ignore that return code and convert the other usage in the code base to also ignore it.