Fix typo in block_errors documentation#10591
Merged
maskit merged 1 commit intoapache:masterfrom Oct 12, 2023
Merged
Conversation
bneradt
approved these changes
Oct 12, 2023
Contributor
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks fine to me. Unless we want to switch things the other way (i.e., we should use enable instead of enabled). But I think that enabled is more typical. So I say go forward with your patch as is.
bryancall
approved these changes
Oct 12, 2023
bryancall
pushed a commit
that referenced
this pull request
Oct 15, 2023
(cherry picked from commit 641704b)
Contributor
|
@maskit We should have a PR for 8.1.x separately so the change can be part of the changelog and tied to 8.1.10. I cherry-picked this change into 9.2.x for the next 9.2.4 release. |
maskit
added a commit
to maskit/trafficserver
that referenced
this pull request
Oct 16, 2023
(cherry picked from commit 641704b) Conflicts: doc/admin-guide/plugins/block_errors.en.rst
Member
Author
bryancall
pushed a commit
that referenced
this pull request
Oct 16, 2023
traeak
pushed a commit
to traeak/trafficserver
that referenced
this pull request
Dec 15, 2023
(cherry picked from commit 641704b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trafficserver/plugins/experimental/block_errors/block_errors.cc
Line 48 in 6c03b16