Cleanup: Move Vol implementations into Vol.cc#10600
Merged
masaori335 merged 1 commit intoapache:masterfrom Oct 17, 2023
Merged
Conversation
masaori335
force-pushed
the
cleanup-cache-13
branch
from
739770c to
cc03ba5
Compare
JosiahWI
approved these changes
Oct 13, 2023
Contributor
JosiahWI
left a comment
JosiahWI
left a comment
There was a problem hiding this comment.
Thanks Masaori, this looks good!
masaori335
force-pushed
the
cleanup-cache-13
branch
from
cc03ba5 to
896ee10
Compare
Contributor
Author
|
Conflicts are resolved. Please take another look. |
masaori335
force-pushed
the
cleanup-cache-13
branch
from
896ee10 to
c36d4d7
Compare
masaori335
force-pushed
the
cleanup-cache-13
branch
from
c36d4d7 to
d76e649
Compare
randall
approved these changes
Oct 17, 2023
Contributor
Author
|
I'm merging this with Randall's approval because no big change after Damian approved this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No logic change.
Note: Many Vol implementations are left in CacheWrite.cc as is. Because we need to figure out CacheRead and CacheWrite code layout.