TS-4920: Consolidate accept socket options. #1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an object AcceptOptions that contains the options to apply to listening sockets, but in many places, the individual options are passed around. Consolidate this so that we pass a AcceptOptions to provide better guarantees that all listening sockets are created equal.
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/912/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/807/ for details. |
Contributor
Author
|
Ping @bryancall @AMC? |
Member
|
@jpeach Good job! And I have my own thoughts on AcceptOptions optimization, but it is quite basic and rough.
|
bneradt
pushed a commit
to bneradt/trafficserver
that referenced
this pull request
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an object AcceptOptions that contains the options to apply
to listening sockets, but in many places, the individual options
are passed around. Consolidate this so that we pass a AcceptOptions
to provide better guarantees that all listening sockets are created
equal.