cmake: adding a release preset#10717
Merged
bryancall merged 1 commit intoapache:masterfrom Nov 3, 2023
Merged
Conversation
Used for benchmarking and users can use it
JosiahWI
approved these changes
Nov 2, 2023
cmcfarlen
approved these changes
Nov 2, 2023
ywkaras
reviewed
Nov 2, 2023
| "generator": "Ninja", | ||
| "binaryDir": "${sourceDir}/build-release", | ||
| "cacheVariables": { | ||
| "CMAKE_BUILD_TYPE": "Release", |
Contributor
There was a problem hiding this comment.
versus "Debug"?
Do -D command line options override the presets?
Contributor
There was a problem hiding this comment.
You can set variables in the cache once it exists:
cmake --preset release
cmake -B build-release -DCMAKE_BUILD_TYPE=Debug
But I do not think CMake supports doing this in one step.
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Nov 4, 2023
Used for benchmarking and users can use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used for benchmarking and users can use it