Add auto options for maxmind_acl, stek_share, and uri_signing plugins#10741
Merged
Conversation
JosiahWI
force-pushed
the
feat/plugin-auto-options
branch
from
28166fa to
09a2619
Compare
This also fixes a bug in Findnuraft.cmake: it added its imported target without checking whether the target already existed.
JosiahWI
force-pushed
the
feat/plugin-auto-options
branch
from
3aea48d to
0089b7d
Compare
cmcfarlen
approved these changes
Nov 10, 2023
Contributor
cmcfarlen
left a comment
cmcfarlen
left a comment
There was a problem hiding this comment.
Looks good. I like how the default follows BUILD_EXPERIMENTAL_PLUGINS
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jan 5, 2024
Auto options were added for the experimental plugins with special dependencies in apache#10741. This adds options for the remaining experimental plugins.
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jan 5, 2024
Auto options were added for the experimental plugins with special dependencies in apache#10741. This adds options for the remaining experimental plugins.
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
Apr 23, 2024
Auto options were added for the experimental plugins with special dependencies in apache#10741. This adds options for the remaining experimental plugins.
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
Apr 23, 2024
Auto options were added for the experimental plugins with special dependencies in apache#10741. This adds options for the remaining experimental plugins.
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
Apr 23, 2024
Auto options were added for the experimental plugins with special dependencies in apache#10741. This adds options for the remaining experimental plugins.
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
Apr 24, 2024
Auto options were added for the experimental plugins with special dependencies in apache#10741. This adds options for the remaining experimental plugins.
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
May 9, 2024
Auto options were added for the experimental plugins with special dependencies in apache#10741. This adds options for the remaining experimental plugins. It was pointed out that WITH_SUBDIRECTORY is giving auto_options too many responsibilities and it will be removed.
JosiahWI
added a commit
to JosiahWI/trafficserver
that referenced
this pull request
May 10, 2024
Auto options were added for the experimental plugins with special dependencies in apache#10741. This adds options for the remaining experimental plugins. It was pointed out that WITH_SUBDIRECTORY is giving auto_options too many responsibilities and it will be removed.
JosiahWI
added a commit
that referenced
this pull request
May 31, 2024
* Add auto options for all experimental plugins Auto options were added for the experimental plugins with special dependencies in #10741. This adds options for the remaining experimental plugins. It was pointed out that WITH_SUBDIRECTORY is giving auto_options too many responsibilities and it will be removed. * Remove WITH_SUBDIRECTORY from auto_option
cmcfarlen
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Add auto options for all experimental plugins Auto options were added for the experimental plugins with special dependencies in #10741. This adds options for the remaining experimental plugins. It was pointed out that WITH_SUBDIRECTORY is giving auto_options too many responsibilities and it will be removed. * Remove WITH_SUBDIRECTORY from auto_option (cherry picked from commit 1036e47)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps clean up the dependency management and gives fine grained control over whether these plugins are built. I am planning to add all the experimental plugins, but I want to get these changes in quickly because we are still in the middle of fixing the plugins, and other PRs can build on these changes.
BUILD_EXPERIMENTAL_PLUGINSdetermines whether these plugins areOFForAUTOon the first configuration. Changing the value ofBUILD_EXPERIMENTAL_PLUGINSsubsequently will not change whether those plugins are built, because their enabled/disabled state is cached separately. I have not come up with a good way to fix this. Suggestions welcome.