Skip to content

Remove HAVE_DLFCN_H build var#10784

Closed
phongn wants to merge 3 commits into
apache:masterfrom
phongn:remove-HAVE_DLFCN_H
Closed

Remove HAVE_DLFCN_H build var#10784
phongn wants to merge 3 commits into
apache:masterfrom
phongn:remove-HAVE_DLFCN_H

Conversation

@phongn
Copy link
Copy Markdown
Collaborator

@phongn phongn commented Nov 14, 2023

Replace automake-style HAVE_INCLUDE_H compile flags with #if __has_include preprocessor directives.

This PR does so for dlfcn.h (which should always exist as a standard header, and thus all guards are removed).

@JosiahWI JosiahWI added Build work related to build configuration or environment CMake work related to CMakes scripts or issues labels Nov 15, 2023
@JosiahWI JosiahWI added this to the 10.0.0 milestone Nov 15, 2023
@phongn phongn force-pushed the remove-HAVE_DLFCN_H branch from ee28d65 to ac69179 Compare November 16, 2023 21:15
dragon512
dragon512 previously approved these changes Nov 16, 2023
dragon512
dragon512 previously approved these changes Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment CMake work related to CMakes scripts or issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants