Skip to content

For vscode users, automatically use ms-vscode.cmake-tools#10810

Merged
zwoop merged 1 commit intoapache:masterfrom
phongn:default-vscode-config-provider
Nov 28, 2023
Merged

For vscode users, automatically use ms-vscode.cmake-tools#10810
zwoop merged 1 commit intoapache:masterfrom
phongn:default-vscode-config-provider

Conversation

@phongn
Copy link
Copy Markdown
Collaborator

@phongn phongn commented Nov 17, 2023

As we move to CMake by default, perhaps it would be useful for VSCode users to automatically set the configuration provider to ms-vscode.cmake-tools?

@dragon512

@dragon512
Copy link
Copy Markdown
Contributor

I don't see an issue with this. @zwoop do you have any concerns?

@dragon512 dragon512 added Build work related to build configuration or environment CMake work related to CMakes scripts or issues labels Nov 17, 2023
@dragon512 dragon512 added this to the 10.0.0 milestone Nov 17, 2023
@bryancall bryancall requested a review from zwoop November 27, 2023 23:43
Copy link
Copy Markdown
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@zwoop zwoop merged commit 3c8e4ca into apache:master Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment CMake work related to CMakes scripts or issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants