Fix netcat usage for accept_timeout test#10856
Closed
shinrich wants to merge 11 commits into
Closed
Conversation
bneradt
reviewed
Dec 12, 2023
|
|
||
| nc_name="nc" | ||
| ncat --help | ||
| if [ $? -le 1 ] |
Contributor
There was a problem hiding this comment.
I'm surprised by -le 1 rather than -eq 0. Do some ncat commands return 1 with --help? I assume checking for 1 is intentional, but just verifying.
Related to this, we might want to consider using the built-in command -v ncat instead of ncat --help.
|
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust to use the reduced argument list for netcat that is available in the ubuntu 22 image.