Coverity 1523682: Out-of-bounds access#10905
Merged
Merged
Conversation
This also fixes cov 1523678 and cov 1523674.
bryancall
approved these changes
Dec 8, 2023
phongn
pushed a commit
to phongn/trafficserver
that referenced
this pull request
Feb 1, 2024
This also fixes cov 1523678 and cov 1523674.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes cov 1523678 and cov 1523674. If not, we can close them as false positives.
Coverity thinks
lenwill be -1 and it becomes a huge positive number when the tests pass them tomemcmpbecause of type difference (int vs size_t). Since we checklen > 0that can't happen but I changed the type to int64_t because the return type of the encode function is int64_t.