Skip to content

Removes experimental.h, moving remaining declarations to ts.h#10918

Merged
zwoop merged 1 commit intoapache:masterfrom
zwoop:RemoveExperimentalH
Jan 23, 2024
Merged

Removes experimental.h, moving remaining declarations to ts.h#10918
zwoop merged 1 commit intoapache:masterfrom
zwoop:RemoveExperimentalH

Conversation

@zwoop
Copy link
Copy Markdown
Contributor

@zwoop zwoop commented Dec 8, 2023

No description provided.

@zwoop zwoop added this to the 10.0.0 milestone Dec 8, 2023
@zwoop zwoop self-assigned this Dec 8, 2023
@bneradt bneradt requested a review from ywkaras December 11, 2023 23:14
=====

This API may be changed in the future version since it is experimental.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this unnecessary blank line seems unrelated to this PR, should be in it's own PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brutal

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to my world.

}

// The API below require timer values as TSHRTime parameters
// which are in nanoseconds. Use the TS_HRTIME macros defined
Copy link
Copy Markdown
Contributor

@ywkaras ywkaras Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it still useful to know the parameters are in nanoseconds?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it’s in the docs

@zwoop zwoop merged commit f691fdc into apache:master Jan 23, 2024
@zwoop zwoop deleted the RemoveExperimentalH branch January 23, 2024 16:43
bneradt pushed a commit to bneradt/trafficserver that referenced this pull request Jan 23, 2024
The apache#10918 PR was old and didn't have the recent cmake formatting
applied. This re-applies our cmake format script to master.
bneradt added a commit that referenced this pull request Jan 23, 2024
The #10918 PR was old and didn't have the recent cmake formatting
applied. This re-applies our cmake format script to master.
phongn pushed a commit to phongn/trafficserver that referenced this pull request Feb 1, 2024
phongn pushed a commit to phongn/trafficserver that referenced this pull request Feb 1, 2024
The apache#10918 PR was old and didn't have the recent cmake formatting
applied. This re-applies our cmake format script to master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants