Skip to content

Copy tsapicore library into /lib#10930

Closed
Skn0tt wants to merge 1 commit intoapache:masterfrom
Skn0tt:fuzz-tsapicore-fix
Closed

Copy tsapicore library into /lib#10930
Skn0tt wants to merge 1 commit intoapache:masterfrom
Skn0tt:fuzz-tsapicore-fix

Conversation

@Skn0tt
Copy link
Copy Markdown
Contributor

@Skn0tt Skn0tt commented Dec 13, 2023

Follow-up to #10889. Running fuzz tests throws error while loading shared libraries: libtsapicore.so: cannot open shared object file: No such file or director. This is because tsapicore is a shared library now, and it needs to be copied into the /lib directory of fuzz tests.

This should fix the fuzzing build (broken since yesterday, take a look at today vs yesterday)

Co-Authored-By: Yannis Hofmann <yannis.hofmann@student.hpi.de>
@Skn0tt
Copy link
Copy Markdown
Contributor Author

Skn0tt commented Dec 13, 2023

Are fuzz tests being built as part of the CI? It might make sense to compile + try running them, so these kinds of regressions can be caught before merging.

@cmcfarlen
Copy link
Copy Markdown
Contributor

tsapicore will be merged with tscpputil to form tsutil in this pr: #10928

The tsutil library will follow the BUILD_SHARED_LIBS variable to determine if it is build static or shared (defaulting to static). So you might have to check that variable to determine if you need to do this strange copy. It looks like I already fixed this in the PR. I'm not sure how the fuzz testing it run or why you need to copy these libraries. Could you point me to some info on that?

@Skn0tt
Copy link
Copy Markdown
Contributor Author

Skn0tt commented Dec 13, 2023

Thanks for pointing that out! I'm also new to the fuzzing tests here. This talks about how to run them locally, but it's a bit involved: https://google.github.io/oss-fuzz/getting-started/new-project-guide/#testing-locally

I can also try running the fuzz tests on #10928 in the coming days, and can double-check if that fixes it.

@shukitchan
Copy link
Copy Markdown
Contributor

Yeah. Perhaps we should wait till after #10928 is done and update this pull request accordingly.

@Skn0tt
Copy link
Copy Markdown
Contributor Author

Skn0tt commented Dec 18, 2023

#10928 seems to have fixed it. Closing!

@Skn0tt Skn0tt closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants