cmake: small fixes to install#10945
Merged
cmcfarlen merged 3 commits intoapache:masterfrom Dec 20, 2023
Merged
Conversation
cmcfarlen
commented
Dec 18, 2023
| ) | ||
|
|
||
| install( | ||
| TARGETS tsapi tsapibackend |
Contributor
Author
There was a problem hiding this comment.
I should have removed this in the prior PR
JosiahWI
reviewed
Dec 18, 2023
| if("$ENV{USER}" STREQUAL root) | ||
| foreach(DIR ${CHOWN_DIRS}) | ||
| message(STATUS "Changing ${DIR} ownership to ${OWNER_USER}:${OWNER_GROUP}") | ||
| message(STATUS "Changing $ENV{DESTDIR}${DIR} ownership to ${OWNER_USER}:${OWNER_GROUP}") |
Contributor
There was a problem hiding this comment.
It shouldn't have ${CMAKE_INSTALL_PREFIX} as well like the line below it?
Contributor
Author
There was a problem hiding this comment.
Actually, the other should look like this one! I missed this picking from internal code. Thanks!
JosiahWI
approved these changes
Dec 18, 2023
Contributor
JosiahWI
left a comment
JosiahWI
left a comment
There was a problem hiding this comment.
This also makes the CMakeUserPresets in .gitignore relative to the .gitignore location.
Looks good.
SolidWallOfCode
approved these changes
Dec 19, 2023
phongn
pushed a commit
to phongn/trafficserver
that referenced
this pull request
Feb 1, 2024
* cmake: small fixes to install * fix post install command * Install yaml-cpp if the build uses the internal version --------- Co-authored-by: Chris McFarlen <cmcfarlen@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.