Add missing ts::records dep to block_errors plugin#10969
Closed
JosiahWI wants to merge 1 commit intoapache:masterfrom
Closed
Add missing ts::records dep to block_errors plugin#10969JosiahWI wants to merge 1 commit intoapache:masterfrom
JosiahWI wants to merge 1 commit intoapache:masterfrom
Conversation
This makes the symbol TS_ALPN_PROTOCOL_HTTP_2_0, which is defined in the records library, visible to the block_errors plugin. Just like apache#10968, this is not a good long term fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the symbol TS_ALPN_PROTOCOL_HTTP_2_0, which is defined in the records library, visible to the block_errors plugin. Just like #10968, this is not a good long term fix.
This may not be the right change for the moment.
TS_ALPN_PROTOCOL_HTTP_2_0is declared inapidefs.hand looks like it's supposed to be part of the API.