http2: Set SSN active on create_stream#11210
Merged
masaori335 merged 1 commit intoapache:masterfrom Apr 5, 2024
Merged
Conversation
bneradt
approved these changes
Apr 4, 2024
Contributor
|
Cherry-picked to v10.0.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Apr 5, 2024
(cherry picked from commit 732006e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to the change, if a HTTP/2 stream is open on a session, but it doesn't make new transaction by some reason, the inactivity timeout of the connection never get fired.
Current ATS v10.0.x cancels inactivity timeout of proxy session in the
Http2ConnectionState::create_stream(introduced by 7d5e673). We need to get back the session inactivity timeout when all streams are gone, but there is a activity check of proxy session. To pass the check, we need to make the proxy session active.trafficserver/src/proxy/http2/Http2ConnectionState.cc
Lines 1994 to 1998 in 66940f5