Skip to content

http2: Set SSN active on create_stream#11210

Merged
masaori335 merged 1 commit intoapache:masterfrom
masaori335:asf-master-h2-ssn-active
Apr 5, 2024
Merged

http2: Set SSN active on create_stream#11210
masaori335 merged 1 commit intoapache:masterfrom
masaori335:asf-master-h2-ssn-active

Conversation

@masaori335
Copy link
Copy Markdown
Contributor

Prior to the change, if a HTTP/2 stream is open on a session, but it doesn't make new transaction by some reason, the inactivity timeout of the connection never get fired.

Current ATS v10.0.x cancels inactivity timeout of proxy session in the Http2ConnectionState::create_stream (introduced by 7d5e673). We need to get back the session inactivity timeout when all streams are gone, but there is a activity check of proxy session. To pass the check, we need to make the proxy session active.

} else if (session->get_proxy_session()->is_active()) {
// If the number of clients is 0, HTTP2_SESSION_EVENT_FINI is not received or sent, and session is active,
// then mark the connection as inactive
session->do_clear_session_active();
session->set_no_activity_timeout();

@masaori335 masaori335 added this to the 10.1.0 milestone Apr 4, 2024
@masaori335 masaori335 self-assigned this Apr 4, 2024
@masaori335 masaori335 merged commit 732006e into apache:master Apr 5, 2024
@cmcfarlen cmcfarlen modified the milestones: 10.1.0, 10.0.0 Apr 5, 2024
@cmcfarlen
Copy link
Copy Markdown
Contributor

Cherry-picked to v10.0.x

cmcfarlen pushed a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: picked-10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants