Skip to content

Remove the -Wno-stringop-overflow warning suppression #11355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
freak82 wants to merge 2 commits into from
+4 −5
Closed

Remove the -Wno-stringop-overflow warning suppression #11355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f50fa5
Remove the need of -Wno-stringop-overflow warning suppression
freak82 May 15, 2024
8379398
Fix undefined behavior doing memcpy from timespec** instead from time…
freak82 May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ add_compile_options(-pipe -Wall -Wextra -Wno-unused-parameter)
add_compile_options(
"$<$<COMPILE_LANGUAGE:CXX>:-Wno-noexcept-type;-Wsuggest-override;-Wno-vla-extension;-fno-strict-aliasing>"
)
add_compile_options("$<$<CXX_COMPILER_ID:GNU>:-Wno-format-truncation;-Wno-stringop-overflow>")
add_compile_options("$<$<CXX_COMPILER_ID:GNU>:-Wno-format-truncation>")

if(NOT EXTERNAL_YAML_CPP)
include(subproject_version)
Expand Down
1 change: 0 additions & 1 deletion lib/swoc/unit_tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ if(CMAKE_COMPILER_IS_GNUCXX)
-Werror
-Wno-unused-parameter
-Wno-format-truncation
-Wno-stringop-overflow
-Wno-invalid-offsetof
)
# stop the compiler from complaining about unused variable in structured binding
Expand Down
4 changes: 2 additions & 2 deletions src/iocore/net/OCSPStapling.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,8 +1169,8 @@ make_url_for_get(TS_OCSP_REQUEST *req, const char *base_url)

// Append '/' if base_url does not end with it
if (url->buf()[url->size() - 1] != '/') {
strncat(url->end(), "/", 1);
url->fill(1);
written = ink_strlcat(url->end(), "/", url->write_avail());
url->fill(written);
}

written = ink_strlcat(url->end(), ocsp_escaped, url->write_avail());
Expand Down
2 changes: 1 addition & 1 deletion src/iocore/net/UnixUDPNet.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ UDPPacket::new_UDPPacket(struct sockaddr const *to, ink_hrtime when, Ptr<IOBuffe
p->p.segment_size = segment_size;
#ifdef HAVE_SO_TXTIME
if (send_at_hint) {
memcpy(&p->p.send_at, &send_at_hint, sizeof(struct timespec));
memcpy(&p->p.send_at, send_at_hint, sizeof(struct timespec));
Copy link
Copy Markdown
Contributor

@brbzull0 brbzull0 May 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh!! this a very good catch.
Must have done some refactor before pushing this and let this slide!!

Please split this into a different PR just in case.
@freak82 thanks for finding and making a PR to fix this!!

Copy link
Copy Markdown
Contributor Author

@freak82 freak82 May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Will close this PR and make new ones.

}
#endif
return p;
Expand Down