Skip to content

Fix undefined behavior doing memcpy from timespec**#11356

Merged
brbzull0 merged 1 commit into
apache:masterfrom
x3me:fix-memcpy-UB
May 15, 2024
Merged

Fix undefined behavior doing memcpy from timespec**#11356
brbzull0 merged 1 commit into
apache:masterfrom
x3me:fix-memcpy-UB

Conversation

@freak82
Copy link
Copy Markdown
Contributor

@freak82 freak82 commented May 15, 2024

The code was wrongly copying from timespec** to timespec*.
There was a warning emitted from GCC 13.2 about this.

…spec*

The code was wrongly copying from timespec** to timespec*.
There was a warning emitted from GCC 13.2 about this.
@brbzull0 brbzull0 added the Bug label May 15, 2024
@brbzull0 brbzull0 added this to the 10.1.0 milestone May 15, 2024
@brbzull0 brbzull0 self-requested a review May 15, 2024 09:07
@brbzull0
Copy link
Copy Markdown
Contributor

Good find, thanks again @freak82.
#11355 (comment)

@JosiahWI
Copy link
Copy Markdown
Contributor

Also fixes CID 1545133 from Coverity.

@ezelkow1
Copy link
Copy Markdown
Member

[approve ci]

@brbzull0
Copy link
Copy Markdown
Contributor

[approve ci autest]

Copy link
Copy Markdown
Contributor

@brbzull0 brbzull0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@brbzull0 brbzull0 merged commit 4dc6bed into apache:master May 15, 2024
@cmcfarlen cmcfarlen modified the milestones: 10.1.0, 10.0.0 May 16, 2024
@cmcfarlen
Copy link
Copy Markdown
Contributor

Cherry-picked to v10.0.x

cmcfarlen pushed a commit that referenced this pull request May 16, 2024
…spec* (#11356)

The code was wrongly copying from timespec** to timespec*.
There was a warning emitted from GCC 13.2 about this.

(cherry picked from commit 4dc6bed)
@freak82 freak82 deleted the fix-memcpy-UB branch May 17, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: picked-10.0.0

Development

Successfully merging this pull request may close these issues.

5 participants