Skip to content

Comments

Update code and build scripts to use latest quiche(0.22.0) release.#11493

Merged
bneradt merged 1 commit intoapache:masterfrom
brbzull0:quiche_0_22_0
Jul 15, 2024
Merged

Update code and build scripts to use latest quiche(0.22.0) release.#11493
bneradt merged 1 commit intoapache:masterfrom
brbzull0:quiche_0_22_0

Conversation

@brbzull0
Copy link
Contributor

@brbzull0 brbzull0 commented Jul 1, 2024

This bumps the quiche version from the build deps scripts and update the code to use latest quiche version which changed some of their API:

  • quiche_conn_stream_recv
  • quiche_conn_stream_send

which now takes an extra param to get the stream application error codes(if any).

Note:
error_code is not used for now. A new PR should add logic to deal with this outcome.

PS: : This needs CI to update quiche to 0.22.0. CI will fail till then.

fixes: #11486

This bumps the quiche version from the build deps scripts and
update the code to use the changed API from quic:
- quiche_conn_stream_recv
- quiche_conn_stream_send

which now takes an extra param to get the detected error(if any).
@brbzull0 brbzull0 added Build work related to build configuration or environment QUIC HTTP/3 quiche libquiche related. labels Jul 1, 2024
@brbzull0 brbzull0 added this to the 10.1.0 milestone Jul 1, 2024
@brbzull0 brbzull0 self-assigned this Jul 1, 2024
@brbzull0
Copy link
Contributor Author

brbzull0 commented Jul 1, 2024

Will not merge this till we have rocky image updated.
Thanks,

@brbzull0
Copy link
Contributor Author

We need #11540 to update some of our images.
cc: @bneradt

bneradt pushed a commit to bneradt/trafficserver-ci that referenced this pull request Jul 15, 2024
@bneradt bneradt merged commit e6a8ac3 into apache:master Jul 15, 2024
bneradt added a commit to apache/trafficserver-ci that referenced this pull request Jul 15, 2024
@cmcfarlen cmcfarlen modified the milestones: 10.1.0, 10.0.0 Jul 21, 2024
@cmcfarlen
Copy link
Contributor

Cherry-picked to v10.0.x

cmcfarlen pushed a commit that referenced this pull request Jul 21, 2024
This bumps the quiche version from the build deps scripts and
update the code to use the changed API from quic:
- quiche_conn_stream_recv
- quiche_conn_stream_send

which now takes an extra param to get the detected error(if any).

(cherry picked from commit e6a8ac3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment HTTP/3 QUIC quiche libquiche related.

Projects

Status: picked-10.0.0

Development

Successfully merging this pull request may close these issues.

Upgrade quiche to latest 0.22.0 version

4 participants