Merged
Conversation
Add an option to slice plugin to only slice large objects.
* Turn cache off only for large and un-sliced requests. * Fix a crash when not conditionally slicing. * Cleanup some function names
* Only store large URLs in metadata cache. * The old stats don't make sense in this new cache. Change metadata stats.
We're not normalizing for un-sliced requests, so don't use CRR.
Contributor
Author
|
[approve ci ubuntu] |
* Add more docs about various cases * Update autest loop
traeak
approved these changes
Aug 12, 2024
Contributor
traeak
left a comment
traeak
left a comment
There was a problem hiding this comment.
This all looks fine and still passes all other tests. Nice and clever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a configuration for slice to limit slicing to large objects only. See documentation change for details.