Disable mptcp if proper header files are not available#11651
Merged
serrislew merged 2 commits intoapache:masterfrom Aug 19, 2024
Merged
Disable mptcp if proper header files are not available#11651serrislew merged 2 commits intoapache:masterfrom
serrislew merged 2 commits intoapache:masterfrom
Conversation
maskit
reviewed
Aug 5, 2024
serrislew
changed the title
bneradt
approved these changes
Aug 19, 2024
Contributor
|
Cherry-picked to v10.0.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Disable mptcp if logging is disabled * open file after cond --------- Co-authored-by: Serris Lew <lserris@apple.com> (cherry picked from commit e922e19)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, to log whether a connection used mptcp, we check the socket option, which requires specific libraries to be available. This is not done when enabling mptcp in our configurations. Therefore, it is possible that we enable mptcp but our logging says we are not using mptcp so that leads to confusion